Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spinner): bounce effect removed #178

Merged
merged 4 commits into from
Sep 17, 2024
Merged

fix(spinner): bounce effect removed #178

merged 4 commits into from
Sep 17, 2024

Conversation

CarloBar1
Copy link
Contributor

@CarloBar1 CarloBar1 commented Sep 17, 2024 •
edited
Loading

Fix AB#16621 - the spinner in autocomplete had a fastidious bouncy behaviour. Fixed via this change.

@CarloBar1 CarloBar1 self-assigned this Sep 17, 2024
@CarloBar1 CarloBar1 requested a review from a team September 17, 2024 08:26
@CarloBar1 CarloBar1 added the bug label Sep 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-17 14:57 UTC

cristinecula
cristinecula requested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@cristinecula cristinecula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should EITHER fix the rotating animation, by replacing the keyframes with these ones OR drop the rotating definition, as it is now unused.

@cristinecula
Copy link
Contributor

I'll update the snapshots

@cristinecula cristinecula merged commit 4bab8c5 into master Sep 17, 2024
5 checks passed
@cristinecula cristinecula deleted the fix/ab16221-spinner-bouncing branch September 17, 2024 14:56
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 8.9.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristinecula cristinecula cristinecula approved these changes

Assignees

@CarloBar1 CarloBar1

Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarloBar1 @cristinecula